Skip to content

private-names (main branch) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

private-names (main branch) #1

wants to merge 1 commit into from

Conversation

mheiber
Copy link
Owner

@mheiber mheiber commented Jul 3, 2018

Do the bare minimium to
get private names to parse.

Added isPrivateName flag to
Identifier interface.

Just accept all the baseline changes.

TODO: parse for real, and fix baselines
for real.

Do the bare minimium to
get private names to parse.

Added `isPrivateName` flag to
`Identifier` interface.

Just accept all the baseline changes.

TODO: parse for real, and fix baselines
for real.
@mheiber mheiber changed the title Hack to parse private names private-names (main branch) Jul 3, 2018
mheiber pushed a commit that referenced this pull request Jul 3, 2018
do a really rough, quick-and-dirty unblock-people job of letting #foo be parse-able.

steps to test:

npm run lint && npm test
See https://bbgithub.dev.bloomberg.com/javascript-guild/typescript-private-fields/ quick start guide for seeing the AST
CI testing coming soon
mheiber pushed a commit that referenced this pull request Jul 3, 2018
do a really rough, quick-and-dirty unblock-people job of letting #foo be parse-able.

steps to test:

npm run lint && npm test
See https://bbgithub.dev.bloomberg.com/javascript-guild/typescript-private-fields/ quick start guide for seeing the AST
CI testing coming soon
mheiber pushed a commit that referenced this pull request Jul 3, 2018
do a really rough, quick-and-dirty unblock-people job of letting #foo be parse-able.

steps to test:

npm run lint && npm test
See https://bbgithub.dev.bloomberg.com/javascript-guild/typescript-private-fields/ quick start guide for seeing the AST
CI testing coming soon
@mheiber mheiber closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant